Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recent bugs, fix kubernetes crd #39

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

f41gh7
Copy link
Collaborator

@f41gh7 f41gh7 commented Jun 15, 2020

removed list-Type=set - fixed kubernetes crd - #37
improved e2e tests tools - added new method WaitForSts WaitForConfigMap, WaitForSecret and WaitForService - #30
added e2e test for alertmanager - #30
added replicaset RBAC for operator service - #36
changed Alertmanager plular name to vmalertmanager - #35

@f41gh7 f41gh7 requested a review from tenmozes June 15, 2020 22:45
removed list-Type=set - fixed kubernetes crd,
improved e2e tests tools - added new method WaitForSts WaitForConfigMap, WaitForSecret and WaitForService,
added e2e test for alertmanager,
added replicaset RBAC for operator service

Signed-off-by: Nikolay Khramchikhin <info@fght.net>
@f41gh7 f41gh7 force-pushed the fixed-list_type-operator_rbac-e2etests branch from 3d01607 to 8268571 Compare June 15, 2020 22:53
Copy link
Contributor

@tenmozes tenmozes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fixes are required

cmd/manager/main.go Show resolved Hide resolved
e2e/utils.go Outdated Show resolved Hide resolved
f41gh7 added 2 commits June 16, 2020 23:46
renamed VmSingle to VMSinle, VmAlert to VMAlert, VmAgent to VMAgent, Alertmanager to VMAlertmanager,
updated default port for VMAlert to 8080,
changed docs and examples
@f41gh7 f41gh7 force-pushed the fixed-list_type-operator_rbac-e2etests branch from 6c59a0a to 6da6770 Compare June 18, 2020 00:21
@f41gh7 f41gh7 merged commit 6e16fa0 into master Jun 18, 2020
@tenmozes tenmozes deleted the fixed-list_type-operator_rbac-e2etests branch August 2, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants